Bruce Momjian <[email protected]> writes:
> + static void
> + rmtree_errno(char *filepath)
> + {
> + if (errno == EACCES)
> + #ifndef FRONTEND
> + elog(LOG, "no permission to remove \"%s\"", filepath);
> + #else
> + fprintf(stderr, "no permission to remove \"%s\"", filepath);
> + #endif
> + else if (errno == EBUSY)
> [ etc ]
This seems awfully bogus: it's incomplete and not in the style of our
other error messages. Why not just one case:
#ifndef FRONTEND
elog(LOG, "could not remove \"%s\": %m", filepath);
#else
fprintf(stderr, "could not remove \"%s\": %s\n", filepath,
strerror(errno));
#endif
Also, I'm unconvinced that LOG is the appropriate error level;
WARNING would probably be better.
regards, tom lane
---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])
