I have confirmed that the attached patch works on Cygwin as well as Windows. Please apply.
cheers
andrew
Andrew Dunstan wrote:
It fixes the build error on Windows - haven't tried because i don't have time, but I know it won't work on Cygwin, because WIN32 isn't (usually) defined on Cygwin - see previous almost endless discussions.
cheers
andrew
Mark Kirkwood wrote:
Andrew Dunstan wrote:
... is apparently broken for Windows and Cygwin. See for example http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=loris&dt=2005-03-16%2001:55:33
Andrew,
The attached patch seems to sort it for me, can you give it try on win32 and cygwin?
cheers
Mark
Index: contrib/pg_buffercache/pg_buffercache_pages.c =================================================================== RCS file: /home/cvsmirror/pgsql/contrib/pg_buffercache/pg_buffercache_pages.c,v retrieving revision 1.1 diff -c -r1.1 pg_buffercache_pages.c *** contrib/pg_buffercache/pg_buffercache_pages.c 12 Mar 2005 15:36:24 -0000 1.1 --- contrib/pg_buffercache/pg_buffercache_pages.c 30 Mar 2005 19:35:59 -0000 *************** *** 17,22 **** --- 17,27 ---- #define NUM_BUFFERCACHE_PAGES_ELEM 6 + #if defined(WIN32) || defined(__CYGWIN__) + extern DLLIMPORT BufferDesc *BufferDescriptors; + extern DLLIMPORT volatile uint32 InterruptHoldoffCount; + #endif + /* * Record structure holding the to be exposed cache data.
---------------------------(end of broadcast)--------------------------- TIP 6: Have you searched our list archives?
http://archives.postgresql.org
