On Thu, Jul 07, 2005 at 03:01:46PM +1200, Mark Kirkwood wrote: > Neil Conway wrote:
> >elog(ERROR) is usually used for "can't happen" errors; also, the usual > >error message in this scenario is "cache lookup failed [...]". Perhaps > >better to use get_typlen() here, anyway. > > I have attached a little change to varlena.c that uses it. I left the > ereport as it was, but am not fussed about it either way. I am, because it gives useless messages to the translators to work on. elog parameters are not marked for translation, ereport are (errmsg and friends, really). So please don't do that. -- Alvaro Herrera (<alvherre[a]alvh.no-ip.org>) "¿Cómo puedes confiar en algo que pagas y que no ves, y no confiar en algo que te dan y te lo muestran?" (Germán Poo) ---------------------------(end of broadcast)--------------------------- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match