Michael Fuhr <[EMAIL PROTECTED]> writes: > Check integer conversion for overflow in datetime functions.
Applied back to 7.4. The patch would not work in 7.3 because we didn't have the DTERR_ convention back then, and it seems not worth the effort to try to deal with the problem that far back. > In one place (line 60 in the patch) the code sets errno to 0 when > it should still be 0 after similar code a few lines above (otherwise > the function would have returned an error). I wasn't sure what > would be preferred: clearing errno again "just to be sure," a comment > explaining why it isn't necessary, or nothing at all. I left it as-is ... regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly