Tom, >> Here is a patch against today's code 1/24. As discussed in -hackers >> consumeInput/parse is removed from being called every single time. It's >> still there for only when the data is sent to the server. > > This appears to be the exact same patch you sent before. Did you > test my suggestion of simply removing the PQconsumeInput call? > I see no reason to add it inside the loop.
My mistake. I'll make the correction. I guess that although parseInput is cheap we could still use a conditional to see when data was sent and only then call it (without PQconsumeInput) instead of calling it every single time PQputCopyData is called. Any objection to that? Alon. ---------------------------(end of broadcast)--------------------------- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match