Tom Lane wrote: > Bruce Momjian <pgman@candle.pha.pa.us> writes: > > Tom Lane wrote: > >> It's still gonna need a configure test and so on. > > > The submitter believes the C macro test is sufficient: > > Do I get to revert the patch the moment that fails in buildfarm?
You bet. In fact I liked his centralizing the WAL close() irrespective of the feature itself. > More to the point, the utility of the patch remains unproven. > We are not in the habit of adding OS dependencies on speculation. He ran tests, though it is speculation because non-caching is a pretty hard thing to find a benefit from except under low memory situations. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073 ---------------------------(end of broadcast)--------------------------- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
