I am waiting for an update from Dmitry.

cheers

andrew

Bruce Momjian wrote:

Is this patch going to be applied?

---------------------------------------------------------------------------

Andrew Dunstan wrote:


I have cleaned this patch somewhat by removing some bitrot that occurred since it was submitted, and adjusting formatting to something more closely resembling postgresql style (please remember to follow our style in future).

The attached works on HEAD and passes the supplied regression tests.

But why do we have to call spi_freeplan? pltcl, which has prepared queries, doesn't require this AFAICS. If memory leaks are an issue, maybe we should bless the object into a class with a DESTROY method that calls spi_freeplan automatically (not sure to do that in XS but I assume it's possible).



---------------------------(end of broadcast)---------------------------
TIP 4: Have you searched our list archives?

              http://archives.postgresql.org

Reply via email to