2006/4/15, Neil Conway <[EMAIL PROTECTED]>:

> On Sat, 2006-04-15 at 01:59 +0200, Nicolas Barbier wrote:
>
>> the following patch changes "parameter" to "gucname" in the grammar
>> (and later references) for the SET syntax in ALTER ROLE and ALTER
>> USER.
>
> Wouldn't "var_name", "varname", or something similar be more clear?
> "GUC" is probably not an acronym we should be exposing prominently to
> the user.

Indeed, that is what people on IRC also told me (after I sent it :-)).
It now uses "varname". Updated patch attached.

Nicolas

--
Nicolas Barbier
http://www.gnu.org/philosophy/no-word-attachments.html
*** ./doc/src/sgml/ref/alter_role.sgml.orig	2006-04-15 01:15:51.000000000 +0200
--- ./doc/src/sgml/ref/alter_role.sgml	2006-04-15 16:24:49.000000000 +0200
***************
*** 36,43 ****
  
  ALTER ROLE <replaceable class="PARAMETER">name</replaceable> RENAME TO <replaceable>newname</replaceable>
  
! ALTER ROLE <replaceable class="PARAMETER">name</replaceable> SET <replaceable>parameter</replaceable> { TO | = } { <replaceable>value</replaceable> | DEFAULT }
! ALTER ROLE <replaceable class="PARAMETER">name</replaceable> RESET <replaceable>parameter</replaceable>
  </synopsis>
   </refsynopsisdiv>
  
--- 36,43 ----
  
  ALTER ROLE <replaceable class="PARAMETER">name</replaceable> RENAME TO <replaceable>newname</replaceable>
  
! ALTER ROLE <replaceable class="PARAMETER">name</replaceable> SET <replaceable>varname</replaceable> { TO | = } { <replaceable>value</replaceable> | DEFAULT }
! ALTER ROLE <replaceable class="PARAMETER">name</replaceable> RESET <replaceable>varname</replaceable>
  </synopsis>
   </refsynopsisdiv>
  
***************
*** 143,149 ****
       </varlistentry>
  
       <varlistentry>
!       <term><replaceable>parameter</replaceable></term>
        <term><replaceable>value</replaceable></term>
        <listitem>
         <para>
--- 143,149 ----
       </varlistentry>
  
       <varlistentry>
!       <term><replaceable>varname</replaceable></term>
        <term><replaceable>value</replaceable></term>
        <listitem>
         <para>
*** ./doc/src/sgml/ref/alter_user.sgml.orig	2006-04-15 01:15:51.000000000 +0200
--- ./doc/src/sgml/ref/alter_user.sgml	2006-04-15 16:25:00.000000000 +0200
***************
*** 36,43 ****
  
  ALTER USER <replaceable class="PARAMETER">name</replaceable> RENAME TO <replaceable>newname</replaceable>
  
! ALTER USER <replaceable class="PARAMETER">name</replaceable> SET <replaceable>parameter</replaceable> { TO | = } { <replaceable>value</replaceable> | DEFAULT }
! ALTER USER <replaceable class="PARAMETER">name</replaceable> RESET <replaceable>parameter</replaceable>
  </synopsis>
   </refsynopsisdiv>
  
--- 36,43 ----
  
  ALTER USER <replaceable class="PARAMETER">name</replaceable> RENAME TO <replaceable>newname</replaceable>
  
! ALTER USER <replaceable class="PARAMETER">name</replaceable> SET <replaceable>varname</replaceable> { TO | = } { <replaceable>value</replaceable> | DEFAULT }
! ALTER USER <replaceable class="PARAMETER">name</replaceable> RESET <replaceable>varname</replaceable>
  </synopsis>
   </refsynopsisdiv>
  



---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend

Reply via email to