I happened to compile entab once again and found couple problems:

- halt.c did not include stdlib.h, thus missed exit() prototype
- Makefile ignores BINDIR for install.
- Makefile calls install with user/group args, thus failing for regular user.

this fixes them.

--
marko
Index: src/tools/entab/Makefile
===================================================================
RCS file: /opt/cvs/pgsql/src/tools/entab/Makefile,v
retrieving revision 1.1
diff -u -r1.1 Makefile
--- src/tools/entab/Makefile	29 Aug 1997 21:12:50 -0000	1.1
+++ src/tools/entab/Makefile	15 Jun 2006 20:45:07 -0000
@@ -23,7 +23,7 @@
 install:
 	make clean
 	make CFLAGS=-O
-	install -s -o bin -g bin $(TARGET) $(BINDIR)
+	install -s $(TARGET) $(BINDIR)
 	rm -f $(BINDIR)/detab
-	ln /usr/local/bin/$(TARGET) $(BINDIR)/detab
+	ln $(BINDIR)/$(TARGET) $(BINDIR)/detab
 
Index: src/tools/entab/halt.c
===================================================================
RCS file: /opt/cvs/pgsql/src/tools/entab/halt.c,v
retrieving revision 1.9
diff -u -r1.9 halt.c
--- src/tools/entab/halt.c	11 Mar 2006 04:38:41 -0000	1.9
+++ src/tools/entab/halt.c	11 Jul 2006 20:00:49 -0000
@@ -10,6 +10,7 @@
 #include <stdarg.h>
 #include <signal.h>
 #include <stdio.h>
+#include <stdlib.h>
 #include <errno.h>
 
 
---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

               http://www.postgresql.org/docs/faq

Reply via email to