Zdenek Kotala wrote: > Peter, > > What is the status of this patch now? I read that two bugs has been > fixed in this patch and now it is waiting for new review. Is there > something what I can/must do?
The patch was applied, fixed, and fixed again, then reverted. It will sit until just before beta, where it will be applied or a vote will be taken on whether to apply it. There is nothing more you have to do on it. I think the fixes just scared some folks so there is hope more review might happen before beta. --------------------------------------------------------------------------- > Zdenek > > Peter Eisentraut wrote: > > Zdenek Kotala wrote: > >> OK. I split patch to two parts. Part one is refactoring of > >> set_config_options function. Part two implements feature "Allow > >> commenting of variables in postgresql.conf to restore them to > >> defaults". > > > > I'm having trouble wrapping my head around a code "refactoring" which > > actually makes the code significantly *longer*. The only interface > > change I could detect is the introduction of a function > > verify_config_option(), which should just be a small variation on > > set_config_option() as it currently exists. > > > > I'm also about a relive a personal trauma if I see error messages like > > this: > > > > errmsg("configuration file is invalid") > > > > I just had to deal with an unnamed product where this was all you got! > > > > Please, explain again what this refactoring is supposed to achieve. > > > > The second part of your patch actually looks pretty reasonable and does > > not appear to require the refactoring. > > -- Bruce Momjian [EMAIL PROTECTED] EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---------------------------(end of broadcast)--------------------------- TIP 5: don't forget to increase your free space map settings