On Sep 1, 2006, at 9:32 , Tom Lane wrote:

Michael Glaesemann <[EMAIL PROTECTED]> writes:
On Sep 1, 2006, at 9:12 , Tom Lane wrote:
I agree that this seems like an oversight in the original
months/days/seconds patch, rather than behavior we want to keep.
But is DecodeInterval the only place with the problem?

I'll check on this tonight. Any idea where I might start to look?

I'd look at the input routines for all the datetime types and see where
they go.  It's entirely possible that DecodeInterval is the only place
with the problem, but I'd not assume that without looking.

AFAICS, DecodeInterval is the only place that needed changing. I've looked through datetime.c, timestamp.c, date.c, and nabstime.c, and don't see anything else. It makes sense, too, as the only place where you could have weeks or non-integer months is during Interval input or interval multiplication/division. The pg_tm struct, which is used in time(stamp)?(tz)?/interval arithmetic only has integral months and no weeks component, so that shouldn't cause any problems. So, I think that's about it.

Michael Glaesemann
grzm seespotcode net

---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend

Reply via email to