On Fri, 19 Jan 2007 17:02, Neil Conway wrote:
> On Sat, 2007-01-20 at 02:28 +1100, FAST PostgreSQL wrote:
> > Attached is a small patch that implements the pg_get_domaindef(oid)
> > function.
>
> A few minor comments:
>
> - don't use C++-style comments

OK. Can do.

>
> - why does this code append a "-" to the output when SPI_processed != 1,
> rather than erroring out?

get_ruledef() does the same.  As the user gets a '-' in that case when a 
non-existent oid is given,  I just wanted to be consistent. Maybe a wrong 
idea ?


>
> - you probably want to elog(ERROR) if typeTuple is invalid:

Of course.

> +               if (typnotnull || constraint != NULL)
> +               {
> +                       if ( ( (contype != NULL) && (strcmp(contype,
> "c") != 0) ) || typnotnull )
> +                       {
> +                               appendStringInfo(&buf, "CONSTRAINT ");
> +                       }
> +                       if (typnotnull)
> +                       {
> +                               appendStringInfo(&buf, "NOT NULL ");
> +                       }
> +               }
> +               if (constraint != NULL)
> +               {
> +                       appendStringInfo(&buf,
> quote_identifier(constraint));
> +               }
>
> This logic seems pretty awkward. Perhaps simpler would be a check for
> typnotnull (and then appending "CONSTRAINT NOT NULL"), and then handling
> the non-typnotnull branch separately.

Yeah agree. 

>
> -Neil

Rgds,
Arul Shaji

This is an email from Fujitsu Australia Software Technology Pty Ltd, ABN 27 003 
693 481. It is confidential to the ordinary user of the email address to which 
it was addressed and may contain copyright and/or legally privileged 
information. No one else may read, print, store, copy or forward all or any of 
it or its attachments. If you receive this email in error, please return to 
sender. Thank you.

If you do not wish to receive commercial email messages from Fujitsu Australia 
Software Technology Pty Ltd, please email [EMAIL PROTECTED]


---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend

Reply via email to