"Pavel Stehule" <[EMAIL PROTECTED]> writes: > This patch correct bug, when localized day or month names was incorectly > trnasformed to lower or upper string.
I really dislike the API you've chosen for upper_str/lower_str --- overwriting the input on the assumption that it's long enough is a buffer overrun bug waiting to happen, because (at least in utf8) changing case doesn't preserve the byte length of the string. Please make them return a freshly palloc'd string instead. regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 7: You can help support the PostgreSQL project by donating at http://www.postgresql.org/about/donate