On Thu, 8 Feb 2007, Alvaro Herrera wrote:

> Bruce Momjian wrote:
> >
> > Is this patch ready for application?

It already has been.

>
> I think the sed usage would cause problems for the VC++ builds.  It
> would be good if the files could be reformulated as files in the input,
> output or data directories; pg_regress would take care to generate the
> files as needed.

It Just Worked with the changes made to pg-regress to support the other,
similar tests (ie, copy).

>
> > ---------------------------------------------------------------------------
> >
> > Jeremy Drake wrote:
> > > This is the latest version of the large object regression test I have been
> > > working on.  Note that a prerequisite for this version of the test is the
> > > patch I made to psql to make it not output on \lo_* commands in quiet mode
> > > is required (also attached, it's small).
> > >
> > > Sorry that it still makes use of the sed trickery like the copy test does,
> > > but:
> > >
> > > 1) I think the server side lo_(import|export) functions need to be tested
> > > as well as the psql variants
> > >
> > > 2) ISTM that making assumptions about the working directory of psql
> > > during
> > > the regression tests would open a can of worms, especially wrt VPATH
> > > builds where the data files could be in a completely separate tree from
> > > the regression tests.
>
>
>

-- 
The human mind treats a new idea the way the body treats a strange
protein -- it rejects it.
                -- P. Medawar

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

Reply via email to