"Simon Riggs" <[EMAIL PROTECTED]> writes:
> WIP patch for diagnostic/test functions for heap pages. (Linked to
> discussion thread on -hackers "HOT - Whats Next?")

--- no security checks; surely these must be superuser-only.

--- relation_open will succeed on things that don't have storage;
better use heap_open (and check it's not a view).

--- most of the validation functions are quite pointless as bufmgr will
refuse to load a page with bad header data.

> Specifically designed to allow test cases to be written that prove that
> HOT works,

Exactly what will these allow that you can't do with inspection of ctid
etc?  (I suspect your answer will be "can't see infomask", but I'd
rather expose that as a new system column than invent functions like
these.)  I'm pretty dubious of the premise anyway --- to get results
sufficiently constant that the current regression test comparison
mechanism works for them, I think you'll have to constrain the test
conditions so much that the test will prove little or nothing.

                        regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
       choose an index scan if your joining column's datatypes do not

Reply via email to