Re: [PATCHES] Patch for pgstatindex to fix a bug reporting a value of strange leaf_fragmentation

[Alvaro Herrera]

Alvaro Herrera wrote:

> Right.  Checking that code, it seems btpo.xact is also being incorrectly
> handled, is it not?  Incidentally, the return value seems a bit useless.

Advertising

Then again, this looks bogus as well.  (Sorry for the unidiff -- I had to
use "interdiff" to get it).

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

diff -u pgstatindex.c pgstatindex.c
--- pgstatindex.c	9 Mar 2007 03:16:30 -0000
+++ pgstatindex.c	9 Mar 2007 03:31:28 -0000
@@ -334,8 +334,7 @@
 		int			j;
 		char	   *values[PGSTATINDEX_NCOLUMNS];
 
-		HeapTupleData tupleData;
-		HeapTuple	tuple = &tupleData;
+		HeapTuple	tuple;
 
 		tupleDesc = RelationNameGetTupleDesc(PGSTATINDEX_TYPE);
 

---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend