Hi!

contrib/spi has a Makefile that uses $(addsuffix) makefile rules for
DATA_built and DOCS. It's the only Makefile in contrib that does it.

I would like to change that to actually listing the modules instead. The
reason for that is that parsing the Makefile for the msvc build will be a
*lot* easier if I don't have to parse $addsuffix rules. And it's not like
it's complex modules it's building.

But I figured I'd post here for approval first. So - would a patch like the
attached be acceptable?

(Again, this only applies to contrib/SPI, I don't *expect* there to be more
such requirements for the other ones)

//Magnus

Index: contrib/spi/Makefile
===================================================================
RCS file: /projects/cvsroot/pgsql/contrib/spi/Makefile,v
retrieving revision 1.26
diff -c -r1.26 Makefile
*** contrib/spi/Makefile        27 Sep 2005 17:13:10 -0000      1.26
--- contrib/spi/Makefile        22 Mar 2007 14:15:46 -0000
***************
*** 1,8 ****
  # $PostgreSQL: pgsql/contrib/spi/Makefile,v 1.26 2005/09/27 17:13:10 tgl Exp $
  
  MODULES = autoinc insert_username moddatetime refint timetravel
! DATA_built = $(addsuffix .sql, $(MODULES))
! DOCS  = README.spi $(addsuffix .example, $(MODULES))
  
  # this is needed for the regression tests;
  # comment out if you want a quieter refint package for other uses
--- 1,8 ----
  # $PostgreSQL: pgsql/contrib/spi/Makefile,v 1.26 2005/09/27 17:13:10 tgl Exp $
  
  MODULES = autoinc insert_username moddatetime refint timetravel
! DATA_built = autoinc.sql insert_username.sql moddatetime.sql refint.sql 
timetravel.sql
! DOCS  = README.spi autoinc.example insert_username.example 
moddatetime.example refint.example timetravel.example
  
  # this is needed for the regression tests;
  # comment out if you want a quieter refint package for other uses
---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster

Reply via email to