Gregory Stark wrote: > "Bruce Momjian" <[EMAIL PROTECTED]> writes: > > > Uh, shouldn't CREATE TABLE LIKE INCLUDING CONSTRAINTS already be including > > any indexes in the parent table? > > You could argue it should for unique indexes since our unique indexes are how > we implement unique constraints. But I see no particular reason to expect it > to copy random other indexes. At least its name doesn't lead one to expect it > to. > > I also thought it was sort of strange to have a command that otherwise is just > copying definitions suddenly start building whole new objects. I think I was > thinking it would be a long slow operation but I suppose creating an empty > index isn't really noticeably slow. It could print a NOTICE similar to what's > printed when you create a primary key or unique constraint. > > It does mean that users would be unable to create a partition, load data, then > build indexes. Perhaps it would be nice to have an ALTER TABLE foo LIKE bar > INCLUDING CONSTRAINTS as well.
The patch already _only_ does constraint(unique) indexes: > So, that's what this patch does. When a table is created with 'CREATE > TABLE ... LIKE parent INCLUDING INDEXES' this iterates over the parent > table indexes looking for constraint indexes, and alters the > CreateStmtContext to include equivalent indexes on the child table. so I am just suggesting it do that always for INCLUDING CONSTRAINTS, with a notice as you suggest. -- Bruce Momjian <[EMAIL PROTECTED]> http://momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---------------------------(end of broadcast)--------------------------- TIP 5: don't forget to increase your free space map settings
