On Mon, May 21, 2007 at 10:48:59AM +0100, Heikki Linnakangas wrote: > >Another problem that I noticed with the patch is that it disregards > >the fillfactor while inserting the tuples. ISTM that this is a correct > >behavior when a tuple is being inserted in the block to preserve cluster > >ordering. But when the tuple is being inserted as a normal operation, > >IMO we should respect the fillfactor. > > > >The easiest way to reproduce this is to insert tuples sorted on the > >cluster index key. > > Actually it does respect the fillfactor when the block suggested by > indexam is full. When you insert tuples sorted on the cluster index key, > the suggested page after the first tuple on the new page is always the > last page. Try inserting in random order instead. > > IOW it's working as designed. But maybe it's not the desired behavior. > Should we have a special case and always respect the fillfactor when > inserting to the last page of the heap?
I think that would be following with least surprise. -- Jim Nasby [EMAIL PROTECTED] EnterpriseDB http://enterprisedb.com 512.569.9461 (cell)
pgpo9LFKNRxPH.pgp
Description: PGP signature
