On 10/8/07, Tom Lane <[EMAIL PROTECTED]> wrote: > "Marko Kreen" <[EMAIL PROTECTED]> writes: > > I noticed strtoull() causes problems on some buildfarm > > machines. As a fix I propose small str2num function inside > > txid.c itself. Main reason is that the txid actually does > > not need fully-featured strtoull (radixes, whitespace skipping). > > Seems like a sane solution to me --- applied. > > (Note that your overflow test didn't actually work; AFAIK there > really isn't any decent solution other than dividing at each step.)
Hmm. It did seem to work here. Just in case I peeked into FreeBSD strtoull() and this patch imitates their method. This also seems to work, but please review, I'm don't feel very sharp anymore... -- marko
txid.overflow.diff
Description: Binary data
---------------------------(end of broadcast)--------------------------- TIP 6: explain analyze is your friend
