Gregory Stark <[EMAIL PROTECTED]> writes:
> "Tom Lane" <[EMAIL PROTECTED]> writes:
>> Hmm.  I'm inclined to reverse the tests (there are 3 not just 1) in
>> heapam.c, so that it explicitly tries to toast only in plain tables,
>> rather than adding more exclusion cases.  Thoughts?

> Well RELKIND_UNCATALOGED can be usefully toasted in that data can be
> compressed internally.

But by the time we are inserting any data that needs compression, the
relkind should not be that anymore.  This would only be an issue if
pg_proc.h itself contained DATA() lines long enough to need toasting.
I argue that that isn't true and isn't likely to become true.  (See
ts_debug() for an example of deliberately avoiding such a case...)

                        regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 7: You can help support the PostgreSQL project by donating at

                http://www.postgresql.org/about/donate

Reply via email to