Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > In the spirit of incremental improvement, here is a patch that turns the > > couple of bools in PGPROC into a bitmask, and associated fallout. > > Maybe declare the field as uint8 instead of char? Otherwise, +1.
I'm wondering if it's safe to do something like MyProc->vacuumFlags |= PROC_FOR_XID_WRAPAROUND without holding the ProcArrayLock. It seems in practice a type smaller than "int" (which uint8 always is) is always stored atomically so this shouldn't be a problem. -- Alvaro Herrera http://www.PlanetPostgreSQL.org/ "La rebeldÃa es la virtud original del hombre" (Arthur Schopenhauer) ---------------------------(end of broadcast)--------------------------- TIP 6: explain analyze is your friend
