Small patch to reduce archive messages to DEBUG1 attached.

-------- Forwarded Message --------
From: Simon Riggs <[EMAIL PROTECTED]>
Cc: Kevin Grittner <[EMAIL PROTECTED]>, Rudolf van der Leeden
Subject: Re: [HACKERS] Postgres 8.3 archive_command
Date: Wed, 21 Nov 2007 18:27:46 +0000

On Wed, 2007-11-21 at 12:24 -0500, Tom Lane wrote:
> "Kevin Grittner" <[EMAIL PROTECTED]> writes:
> > Tom Lane <[EMAIL PROTECTED]> wrote: 
> >> Just to clarify: I don't object to lowering "successfully archived"
> >> messages to DEBUG1, if the field consensus is that it's too chatty.
> >> What I didn't like was the idea of logging some events but not other
> >> identical events.
> > Agreed on the intermittent logging.  I don't feel it's too chatty,
> > but on the other hand, I could always change the logging level on
> > the fly if I was investigating a problem, so it wouldn't be much of
> > an inconvenience to switch it if it bugs others.
> Also, you can always tweak your archive_command script to do some
> logging of its own, so it's always possible to make the thing more
> noisy if you need to.  Less noisy, though, is hard without changing
> the server code.

OK, both of those thoughts are good, so happy now with DEBUG1 for
success messages: "archived transaction log file..."

Enclosed patch to set archived message to DEBUG1.

I've got a few other comments for PITR docs, so I'll mention this also
in forthcoming patch.

  Simon Riggs
Index: src/backend/postmaster/pgarch.c
RCS file: /home/sriggs/pg/REPOSITORY/pgsql/src/backend/postmaster/pgarch.c,v
retrieving revision 1.32
diff -c -r1.32 pgarch.c
*** src/backend/postmaster/pgarch.c	15 Nov 2007 21:14:37 -0000	1.32
--- src/backend/postmaster/pgarch.c	21 Nov 2007 17:37:52 -0000
*** 492,498 ****
  		return false;
! 	ereport(LOG,
  			(errmsg("archived transaction log file \"%s\"", xlog)));
  	return true;
--- 492,498 ----
  		return false;
! 	ereport(DEBUG1,
  			(errmsg("archived transaction log file \"%s\"", xlog)));
  	return true;
---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
       choose an index scan if your joining column's datatypes do not

Reply via email to