Tom Lane wrote:
Andrew Dunstan <[EMAIL PROTECTED]> writes:
Tom Lane wrote:
This doesn't look quite right; unless the arithmetic is being done in
floating point?  I had it like this in

RELSEG_SIZE=`expr '(' 1024 '*' ${segsize} / ${blocksize} ')' '*' 1024`

blocksize is one of (1,2,4,8,16,32) so it should always be a factor of 1024 unless my arithmetic is awry. I did it that way because I dislike expressions with unbracketed mixed operations - they make me think too much.

Well, if you dislike the original on style grounds, you should change it
to match.  Doing the same thing in two different ways in two places
isn't good.

OK, done. Patch applied with that addition (it was time I deployed autoconf 2.61 anyway).



Sent via pgsql-patches mailing list (
To make changes to your subscription:

Reply via email to