Bruce Momjian wrote: > I moved str_initcap() over into oracle_compat.c and then had initcap() > convert to/from TEXT to call it. The code is a little weird because > str_initcap() needs to convert to text to use texttowcs(), so in > multibyte encodings initcap converts the string to text, then to char, > then to text to call texttowcs(). I didn't see a cleaner way to do > this.
Why not use wchar2char? It seems there's room for extra cleanup here. Also, the prototype of str_initcap in builtins.h looks out of place. -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches
