On Sat, 2008-07-05 at 11:24 -0400, Tom Lane wrote:

> the remaining toggles aren't really toggles.

If it *acts* like a toggle and the help *says* its a toggle, then its
"actual toggleness" seems moot.

At the very least we should document the two toggles that are already
settable, with the attached patch.

-- 
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support
Index: src/bin/psql/help.c
===================================================================
RCS file: /home/sriggs/pg/REPOSITORY/pgsql/src/bin/psql/help.c,v
retrieving revision 1.129
diff -c -r1.129 help.c
*** src/bin/psql/help.c	11 Jun 2008 10:55:43 -0000	1.129
--- src/bin/psql/help.c	5 Jul 2008 12:19:00 -0000
***************
*** 228,237 ****
  	fprintf(output, _("  \\pset NAME [VALUE]  set table output option\n"
  					  "                 (NAME := {format|border|expanded|fieldsep|footer|null|\n"
  					  "                 numericlocale|recordsep|tuples_only|title|tableattr|pager})\n"));
! 	fprintf(output, _("  \\t             show only rows (currently %s)\n"),
  			ON(pset.popt.topt.tuples_only));
  	fprintf(output, _("  \\T [STRING]    set HTML <table> tag attributes, or unset if none\n"));
! 	fprintf(output, _("  \\x             toggle expanded output (currently %s)\n"),
  			ON(pset.popt.topt.expanded));
  	fprintf(output, "\n");
  
--- 228,237 ----
  	fprintf(output, _("  \\pset NAME [VALUE]  set table output option\n"
  					  "                 (NAME := {format|border|expanded|fieldsep|footer|null|\n"
  					  "                 numericlocale|recordsep|tuples_only|title|tableattr|pager})\n"));
! 	fprintf(output, _("  \\t [on|off]    show only rows (currently %s)\n"),
  			ON(pset.popt.topt.tuples_only));
  	fprintf(output, _("  \\T [STRING]    set HTML <table> tag attributes, or unset if none\n"));
! 	fprintf(output, _("  \\x [on|off]    toggle expanded output (currently %s)\n"),
  			ON(pset.popt.topt.expanded));
  	fprintf(output, "\n");
  
-- 
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches

Reply via email to