Andrew Chernow escribió:
> !
> printfPQExpBuffer(&conn->errorMessage,
> !
> libpq_gettext("PGEventProc \"%s\" failed during PGEVT_CONNRESET event\n"),
> ! conn->events[i].name);
> ! else
> !
> printfPQExpBuffer(&conn->errorMessage,
> !
> libpq_gettext("PGEventProc \"addr:%p\" failed during PGEVT_CONNRESET
> event\n"),
> ! conn->events[i].proc);
> ! break;
Please don't do this. It creates extra unnecessary work for
translators. Better create a local var, assign either "name" or
"addr:<value>" to it, and then use that in the message.
(For the record, I'd prefer that the name is made mandatory.)
Oh, BTW: don't post to pgsql-patches. It's deprecated. Use
pgsql-hackers instead.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
--
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches
