Magnus Hagander wrote: > Also, the patch needs error checking. strftime() can fail, and the > multibyte conversion functions can certainly fail. That will need to be > added.
What about this line? #define STRLEN_MAX 255 Are we really sure the strftime format cannot be longer than that? -- Alvaro Herrera http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches
