On Thu, 2005-03-03 at 00:25, Tom Lane wrote:
> Bret Hughes <[EMAIL PROTECTED]> writes:
> > create function int2ts(integer) returns timestamp  as '
> > SELECT ( TIMESTAMP WITH TIME ZONE \'epoch\' + $1 * INTERVAL \'1
> > second\')::timestamp without time zone;
> > ' language sql;
> 
> > create function ts2int(timestamp without time zone) returns int as '
> > select extract( \'epoch\' from $1)::integer;
> > ' language sql;
> 
> Looks good as far as it goes.  Two thoughts:
> 
> * both functions should probably be marked STRICT STABLE
> (not IMMUTABLE, because they depend on the local timezone setting).
> 
> * have you considered allowing the numeric values to be float8 instead
> of integer?  There doesn't seem any reason to disallow sub-second
> precision.
> 

well no I had not considered it but am now :)

I need to read some more as to the STRICT STABLE stuff, thanks for the
tips.

Bret


---------------------------(end of broadcast)---------------------------
TIP 9: the planner will ignore your desire to choose an index scan if your
      joining column's datatypes do not match

Reply via email to