Re: [Pharo-dev] bug: [4993] Typing cmd+L cancel all typing and we can't undo it [Terminated]

[btc]

Marcus Denker wrote: On Oct 13, 2013, at 4:10 PM, b...@openinworld.com wrote: kilon wrote: This is my first pharo bug fix so be gentle :D https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-we-can-t-undo-it <https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-we-can-t-undo-it> As I explain in the link and in my commit log , I have added a confirm dialog so the user in case he accidentally pressed CMD+L will click no and his changes will not be lost. I have verified the bug fix with the latest pharo build. -- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-undo-it-Terminated-tp4714154.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com. It looks fine. Simple enough even for me to understand ;). So I've changed the status to 'Resolved - fix to include.' Actually my first, so just checking this is the correct next step in the workflow ? Normally the first step is "fix review needed". Then someone else needs to check if this is ok (not any small mistake, problem really solved), "fix to include" should be the state when it is guaranteed that is can be included without check and thinking. Marcus After loading the slice, as well as some functional testing, would you typically run all tests in TestRunner, or just those associated with the modified package ?  Also at which point does the monkey do its checking? cheers -ben