Re: [Pharo-dev] bug: [4993] Typing cmd+L cancel all typing and we can't undo it [Terminated]

[btc]

Alexandre Bergel wrote: Hi! Thanks Kilon for working on the Contr-l key binding. I use this control key binding a lot, and actually, it is really rare when I do a mistake. Having to press OK whenever I do this sounds like a regression to me. Why not always inserting the text in the undo queue before replacing the text? Alexandre I originally had the same opinion, and I had a go getting undo to work but failed.  So I tested kilon's slice and it seemed to not adversely affect my workflow.  I wonder if a compromise might be the ability to acknowledge the alert dialog with <ctrl-l> - so you don't have to move your fingers from the shortcut, and still provides a guard against accidental reset. -ben Le 13-10-2013 à 8:08, kilon <theki...@yahoo.co.uk> a écrit : This is my first pharo bug fix so be gentle :D https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-we-can-t-undo-it <https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-we-can-t-undo-it> As I explain in the link and in my commit log , I have added a confirm dialog so the user in case he accidentally pressed CMD+L will click no and his changes will not be lost. I have verified the bug fix with the latest pharo build. -- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-undo-it-Terminated-tp4714154.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.