On 10 December 2013 14:47, Nicolas Cellier < [email protected]> wrote:
> A fact is that there are way too many methods in (Sequenceable)Collection > already, with duplicated implementations/features. > So if collect:as: does the job why the hell add yet another selector? > > +1 > > 2013/12/10 Roberto Minelli <[email protected]> > >> IMHO having two common usages of #flatCollect:as: and #collect:as: is >> good. Then, do whatever you want. In my image I have #collectAsSet:. >> >> On Dec 10, 2013, at 2:40 PM, Esteban Lorenzano <[email protected]> >> wrote: >> >> > IMO, if there is an error, then is the presence of #flatCollectAsSet:, >> not the absence of the other(s). >> > >> > Esteban >> > >> > >> > On Tue, Dec 10, 2013 at 2:38 PM, Nicolas Cellier < >> [email protected]> wrote: >> > And then rejectAsSet: selectAsHeap: etc... >> > A big -1 >> > >> > >> > 2013/12/10 Yuriy Tymchuk <[email protected]> >> > >> > On 10 Dec 2013, at 14:26, Roberto Minelli <[email protected]> >> wrote: >> > >> > > No. Since #flatCollectAsSet: is in the image, #collectAsSet: should >> be in the image as well. >> > > >> > > And then, since we want clean code #collectAsSet: is cleaner than >> #collect:as:. >> > >> > Yes, but this also means that you need to implement: >> > >> > collectAsArray: >> > collectAsOrderedCollection: >> > collectAsBag: >> > … >> > >> > :) >> > >> > > >> > > On Dec 10, 2013, at 2:23 PM, Esteban Lorenzano <[email protected]> >> wrote: >> > > >> > >> I don't think it has to be in the image, >> > >> >> > >> After all, you can just replace your calls for #collect:as: >> > >> >> > >> Esteban >> > >> >> > >> >> > >> >> > >> >> > >> On Tue, Dec 10, 2013 at 2:21 PM, Roberto Minelli < >> [email protected]> wrote: >> > >> Hi, >> > >> >> > >> In Pharo 3 you guys integrated Doru’s CollectionsExtension package, >> which is great. >> > >> >> > >> You forgot, however, to integrate the utility method #collectAsSet: >> I was using in several places in my code. >> > >> >> > >> It should be simply >> > >> ^ self collect: aBlock as: Set >> > >> >> > >> Could someone please put this in the standard image please? Thanks. >> > >> >> > >> Cheers, >> > >> R >> > >> >> > > >> > > >> > >> > >> > >> > >> >> >> > -- Best regards, Igor Stasenko.
