I think we should use Metacello versions for this, no?

Doru

Sent from my iPhone

On Jan 20, 2014, at 15:39, Sven Van Caekenberghe <[email protected]> wrote:

> 
> On 20 Jan 2014, at 15:30, Tudor Girba <[email protected]> wrote:
> 
>> Ohh, I misread the mail. Sorry.
>> 
>> Sebastian: I just checked, and you have commit rights to PharoExtras, so you 
>> could just commit your fix to the RFB project.
> 
> But if he does that, RFB will no longer work on 2.0
> 
> And for such a small difference, having two code versions is silly, so the 
> only solution is a dynamic hack (try one, if failed, try the other).
> 
>> Doru
>> 
>> 
>> On Mon, Jan 20, 2014 at 3:27 PM, Sven Van Caekenberghe <[email protected]> wrote:
>> 
>> On 20 Jan 2014, at 15:26, Tudor Girba <[email protected]> wrote:
>> 
>>> Thank you.
>>> 
>>> Could you please open an issue and propose a slice for this?
>> 
>> RFB is an external package, right ?
>> 
>>> Doru
>>> 
>>> 
>>> On Mon, Jan 20, 2014 at 1:57 PM, Sebastian Sastre 
>>> <[email protected]> wrote:
>>> Hi there,
>>> 
>>> this is causing a debugger to be open in the deprecated method
>>> 
>>> 
>>> RFBSession>>desktopName
>>>        "Answer the name of the desktop, constructed from the image, host 
>>> and platform names."
>>>        "RFBSession new desktopName"
>>> 
>>>        ^String streamContents: [:stream |
>>>                stream
>>>                        nextPutAll: SmalltalkImage current imageName 
>>> asFileReference basename;
>>>                        nextPut: $@;
>>>                        nextPutAll: server localHostName;
>>>                        nextPutAll: ' [';
>>>                        nextPutAll: OSPlatform platformName; space; 
>>> nextPutAll: OSPlatform osVersion;
>>>                        nextPut: $].
>>>                interactive ifFalse: [stream nextPutAll: ' - view only']]
>>> 
>>> 
>>> fix:
>>> 
>>> 
>>> RFBSession>>desktopName
>>>        "Answer the name of the desktop, constructed from the image, host 
>>> and platform names."
>>>        "RFBSession new desktopName"
>>> 
>>>        ^String streamContents: [:stream |
>>>                stream
>>>                        nextPutAll: SmalltalkImage current imageName 
>>> asFileReference basename;
>>>                        nextPut: $@;
>>>                        nextPutAll: server localHostName;
>>>                        nextPutAll: ' [';
>>>                        nextPutAll: Smalltalk os name; space; nextPutAll: 
>>> Smalltalk os  version;
>>>                        nextPut: $].
>>>                interactive ifFalse: [stream nextPutAll: ' - view only']]
>>> 
>>> 
>>> 
>>> --
>>> www.tudorgirba.com
>>> 
>>> "Every thing has its own flow"
>> 
>> 
>> 
>> 
>> 
>> -- 
>> www.tudorgirba.com
>> 
>> "Every thing has its own flow"
> 
> 

Reply via email to