Re: [Pharo-dev] #windowIsClosing not sent to model of WindowModel

[btc]

Benjamin wrote: On 20 Jan 2014, at 14:37, b...@openinworld.com wrote: I don't want to unsubscribe #refresh in PhLTitledTreeModel>>initialize. I _really_ want to unsubscribe #refresh immediately after the subscribe #refresh is set up. But it does not prevent you to register to the event whenever you want :) Could you give a try and tell me? I gave this a try and indeed #whenBuiltDo: works from #initialize.  However in PharoLauncher <Create Image> stopped updating the list.  After a bit of a muddling around I found that I am prevented from registering the event "wherever I wanted", since the subscription does not go to theValueHolder but to the contents of theValueHolder.   So the event really can only be registered when the ValueHolder content is set in the #repository: method. That is as far as I can push this for now.  I have a working solution with previously proposed ComposableModel>>topWindowHolder and ComposableModel>>whenWindowClosed: so I will proceed with that.  Any objections to pushing these into Pharo 3 at this late stage :) and I'll just make them extensions from PharoLauncher. cheers -ben I tried to avoid calling in #windowHolder but would that preferred? Do you have another suggestion? I was not talking about the name, more the implementation :P (but not more than #window :) ) btw, the 'window' i-var of ComposableModel seems like it should be 'windowHolder' I think all the other variable should be name without holder at the end :) Ben