Re: [Pharo-dev] Help needed! ClassTest>>#testRenaming

[btc]

Pharo4Stef wrote: Hope we can sort this out, more and more fixes suffer from the wrong testing failures and nothing new gets integrated. yes I’m sorry about that. Marcus is burnt out. Esteban is on vacation and I’m out of time managing our team and other duties. For the issues related to rpackage I will let esteban looked at them because he worked a lot on them. I see there is progress on Case 12995 with a monkey validated solution that modifies...     RPackageOrganizer>>systemCategoryRemovedActionFrom:. I have an alternate monkey validated solution on Case 13021 that modifies...     CompiledMethodTest>>testIsInstalled    CompiledMethodTest>>testMethodClass    CompiledMethodTest>>testSearchForClass    CompiledMethodTest>>testSearchForSelector    CompiledMethodTest>>testSelector Case 12995 is probably required anyway and may make 13021 unnecessary, but 13021 seems lower risk and to clear the way for other pending resolved cases maybe faster to integrate - depending on how much more consideration 12995 needs.  Anyway, looks like there is soon a way forward. cheers -ben 12996 ClassTest>>#testRenaming leaves dirty package Dummy-Tests-Class behind 12995 CI ClassTest>>#testRenaming is failing available options: 1. skip test 2. test for nil in RPackageOrganizer>>#systemClassRenamedActionFrom:    before    rPackage updateDefinedClassNamed: oldName withNewName: newName. 3. review changes for issue 12601     (fix RPackageOrganizer>>#systemCategoryRemovedActionFrom: ann, to     unregister packages even if there are MCPackages (don't know about the     side effects) best solution would be number 3, but the recent submissions for issue 12601 are quite complex, so I don't know. Nicolai