I’d gladly submit improvements, but I need some background knowledge. What’s the plan? It looks like SmalllintManifestChecker is just overriding/fixing stuff that is wrong in RBSmalllintChecker.
For example RBSmalllintChecker>>checkClass: does: “(environment includesClass: aClass) ifTrue:” while SmalllintManifestChecker>>runRules:onPackage:withoutTestCase: does: “(environment definesClass: class) ifTrue:”. SmalllintManifestChecker>>runRules:onPackage: doesn’t do this check despite that fact that it should work similarly to SmalllintManifestChecker>>runRules:onPackage:withoutTestCase:. Do we need to flatten SmalllintManifestChecker into RBSmalllintChecker? What is the status, is anyone working on it with some purpose or not? Also SmallLint is tied with RB. Is RB going to change or not? Uko On 22 May 2014, at 18:54, stepharo <[email protected]> wrote: > If you improve the system send us fixes. > Just make sure that > - the tests run > - you add tests. > > Stef >
