On Mon, Jun 23, 2014 at 11:45 AM, Esteban A. Maringolo <[email protected] > wrote:
> Eliot, > > I never installed your proposed changes in a Pharo 3 image because > there is a significant change in ContextPart. Your proposed changeset > changes classVars of ContextPart. > > Your proposal: > classVariableNames: 'MaxLengthForASingleDebugLogReport > MaxStackDepthForASingleDebugLogReport PrimitiveFailToken QuickStep > ValueIndex' > > Current vars: > classVariableNames: 'PrimitiveFailToken QuickStep > SpecialPrimitiveSimulators TryNamedPrimitiveTemplateMethod' > Obviously my change set was for Squeak, and the def above is for Pharo. So the two definitions need to be merged. Did you try the union of the class variable names? > > Would you mind adapting your mirror methods changes to work also in > Pharo 3 (and maybe in Pharo 4 too?). > > Esteban A. Maringolo > > > 2014-02-26 14:40 GMT-03:00 Eliot Miranda <[email protected]>: > > Hi Esteban, > > > > find attached. Let me know of any problems. > > > > > > On Wed, Feb 26, 2014 at 8:32 AM, Esteban A. Maringolo < > [email protected]> > > wrote: > >> > >> Hi Eliot, > >> > >> > >> 2013-11-30 18:30 GMT-03:00 Eliot Miranda <[email protected]>: > >> > On Fri, Nov 29, 2013 at 2:22 PM, Esteban A. Maringolo > >> > <[email protected]> > >> > wrote: > >> >> 2013/11/29 Eliot Miranda <[email protected]>: > >> > >> >> > I'll either prepare a change set or submit. It'll get done. > >> > >> >> I can continue stepping into until the change is ready. > >> > >> >> Please make it compatible with Pharo 2 (whatever that means in term > of > >> >> code) :) > >> > > >> > > >> > OK, the code is now in Squeak trunk. What image should I use to > >> > integrate > >> > into Pharo 2? A url please... > >> > >> I'm coming back late to this. Because the change wasn't integrated in > >> Pharo 2. > >> > >> Do you have the changeset applied to Squeak Trunk? I'd like to reapply > >> it in my Pharo 2 image (at my own risk). > >> Can you send it to may email address? > >> > >> Thank you! > >> > >> Esteban A. Maringolo > >> > > > > > > > > -- > > best, > > Eliot > > -- best, Eliot
