On 26 Jun 2014, at 08:13, Sven Van Caekenberghe <[email protected]> wrote:
> I reopened https://pharo.fogbugz.com/f/cases/13395/Add-SHA256-HashFunction > Why? i fixed that already yesterday (by renaming the class so the default works…) Is it important to re-name it again and add the #classToBeTested? > On 26 Jun 2014, at 07:45, stepharo <[email protected]> wrote: > >> no problem open a bug entry. >> >> Stef >> >> On 25/6/14 10:37, Sven Van Caekenberghe wrote: >>> On 25 Jun 2014, at 10:06, [email protected] wrote: >>> >>>> https://ci.inria.fr/pharo/job/Pharo-4.0-Update-Step-2.1-Validation-M-Z/label=mac/45/ >>>> >>>> 5 regressions found. >>>> Tests.System.Hashing.SHA256Tests.testClassComment >>>> Tests.System.Hashing.SHA256Tests.testMethodsOfTheClassShouldNotBeRepeatedInItsSuperclasses >>>> Tests.System.Hashing.SHA256Tests.testNew >>>> Tests.System.Hashing.SHA256Tests.testTraitExplicitRequirementMethodsMustBeImplementedInTheClassOrInASuperclass >>>> Tests.System.Hashing.SHA256Tests.testUnCategorizedMethods >>> I didn't see that SHA256Tests subclassed ClassTestCase (I copied it from >>> SHA1Test), this needs to be added in protocol 'coverage' of SHA256Tests, >>> instance side: >>> >>> classToBeTested >>> ^ SHA256 >>> >>> Sorry about that. >>> >>> Sven >>> >> >> > >
