2014-08-04 8:50 GMT+02:00 Henrik Johansen <[email protected]>:
> > On 03 Aug 2014, at 5:55 , Clément Bera <[email protected]> wrote: > > > > > > > Right, current hash is bad and long to compute. > > > > I think we should use instead > > BasicIndexedEyeElement >> hash > > ^ index hashMultiply > > > > host identityHash and index hash may lead to many collisions... > > What do you think ? > > > > I agree there’s not much value in including host in the hash for the use > case of the icon lookup cache, since those were per host anyways (iirc). > Index hash will be a sequential number, I haven’t checked the usage > closely to see if it’ll be a problem wrt. collisions, but removal at least > might be slow (if that’s ever done) due to lots of scanning needed to find > the nil slot. Using hashMultiply seems a good precaution. > > Cheers, > Henry > And as far as I know, the icon lookup isn't needed for the inspector, as it does not show any icons at all!
