> On 22 Jan 2015, at 18:15, Marcus Denker <[email protected]> wrote:
> 
> 
>> On 22 Jan 2015, at 18:06, Aliaksei Syrel <[email protected]> wrote:
>> 
>> And I also think that InstanceVariableSlot >>definitionString in subclasses 
>> should return self printString and not only its name
>> 
> 
> The thing is that we have two cases:
> 
> 1) Full definition          {#slot => PropertySlot}
> 2) shortened definition  { #ivar }
> 
> the later one is for “normal” instance variables (and globals), for all the 
> cases where slots just model what we have now.
> 
> the #isSpecial check returns false for those and true for all other slots.
> 
> I think we should implement definitionString in InstanceVariableSlot to check 
> isSpecial and call the super
> class method for the case when it is. This way it will work even for 
> subclasses as expected.
> 

This is fixed with

        
https://pharo.fogbugz.com/f/cases/14779/fix-definitionString-for-subclasses-of-ClassVariable-and-IntanceVariableSlot
 
<https://pharo.fogbugz.com/f/cases/14779/fix-definitionString-for-subclasses-of-ClassVariable-and-IntanceVariableSlot>


        Marcus

Reply via email to