> On 15 Apr 2015, at 14:45, Sven Van Caekenberghe <[email protected]> wrote: > > Yes, I can confirm your issue. > > But using World Menu > Tools > Finder to search in Source does work well.
Probably because the Finder does not search in class comments, only in method sources. Maybe we need a unit test to check the validity of all class comments ? >> On 15 Apr 2015, at 14:36, Nicolai Hess <[email protected]> wrote: >> >> pharo 4.0 608 with PharoV40 sources: >> >> - enter some text in a workspace >> - select the text >> - choose "Method source with it" >> >> -> >> RemoteString(Object)>>error: >> [ >> filePositionHi > theFile size >> ifTrue: [ self error: 'RemoteString past end of file' ]. >> theFile position: filePositionHi. >> theFile nextChunk ] in RemoteString>>string in Block: [ ... >> BlockClosure>>ensure: >> RemoteString>>string >> ClassOrganization>>comment >> ClassOrganization>>classComment >> [ :each | >> bar current: (count := count + 1). >> each >> selectorsDo: [ :sel | >> ((each sourceCodeAt: sel) includesSubstring: aString caseSensitive: >> caseSensitive) >> ifTrue: [ addMethod value: each value: sel ] ]. >> (each organization classComment asString includesSubstring: aString >> caseSensitive: caseSensitive) >> ifTrue: [ addComment value: each ] ] in [ :bar | >> | count | >> count := 0. >> self >> allBehaviorsDo: [ :each | >> bar current: (count := count + 1). >> each >> selectorsDo: [ :sel | >> ((each sourceCodeAt: sel) includesSubstring: aString >> caseSensitive: caseSensitive) >> ifTrue: [ addMethod value: each value: sel ] ]. >> (each organization classComment asString includesSubstring: aString >> caseSensitive: caseSensitive) >> ifTrue: [ addComment value: each ] ] ] in >> SystemNavigation>>allMethodsWithSourceString:matchCase: in Block: [ :each | >> ... >> [ :aClass | >> aBlock >> value: aClass; >> value: aClass class ] in SystemNavigation>>allBehaviorsDo: in Block: [ >> :aClass | ... >> [ :name | aBlock value: (self at: name) ] in SystemDictionary>>allClassesDo: >> in Block: [ :name | aBlock value: (self at: name) ] >> OrderedCollection>>do: >> SystemDictionary>>allClassesDo: >> SystemNavigation>>allBehaviorsDo: >> [ :bar | >> | count | >> count := 0. >> self >> allBehaviorsDo: [ :each | >> bar current: (count := count + 1). >> each >> selectorsDo: [ :sel | >> ((each sourceCodeAt: sel) includesSubstring: aString >> caseSensitive: caseSensitive) >> ifTrue: [ addMethod value: each value: sel ] ]. >> (each organization classComment asString includesSubstring: aString >> caseSensitive: caseSensitive) >> ifTrue: [ addComment value: each ] ] ] in >> SystemNavigation>>allMethodsWithSourceString:matchCase: in Block: [ :bar | >> ... >> BlockClosure>>cull: >> [ result := block cull: self ] in [ >> self prepareForRunning. >> [ result := block cull: self ] >> on: JobNotification >> do: [ :notification | notification handle: self ] ] in Job>>run in Block: >> [ result := block cull: self ] >> BlockClosure>>on:do: >> [ >> self prepareForRunning. >> [ result := block cull: self ] >> on: JobNotification >> do: [ :notification | notification handle: self ] ] in Job>>run in Block: >> [ ... >> BlockClosure>>ensure: >> Job>>run >> MorphicUIManager(UIManager)>>displayProgress:from:to:during: >> ByteString(String)>>displayProgressFrom:to:during: >> SystemNavigation>>allMethodsWithSourceString:matchCase: >> SystemNavigation>>browseMethodsWithSourceString:matchCase: >> [ :aPresentation | >> aPresentation selectLine. >> self systemNavigation browseMethodsWithSourceString: aPresentation >> selectedText matchCase: false ] in >> GLMPharoPlaygroundPresentation(GLMRubricSmalltalkCodePresentation)>>browsingSelectionActions >> in Block: [ :aPresentation | ... >> BlockClosure>>glamourValueWithArgs: >> GLMGenericAction(GLMAction)>>actOn: >> GLMGenericAction(GLMAction)>>morphicActOn: >> [ :ann | ann action morphicActOn: aPresentation ] in >> GLMMorphicPharoPlaygroundRenderer(GLMMorphicWidgetRenderer)>>installActionsOnModel:fromPresentation: >> in Block: [ :ann | ann action morphicActOn: aPresentation ] >> BlockClosure>>cull: >> BlockClosure>>cull:cull: >> >
