Thank you for testing. I am sorry but I missed one additional change. This change set issue_14183.cs did not revert all. The one thing I was missing is a change in AthensCairoSurface class>>createGetSurfaceFormatFn here, it tells the bitblt the size of the external form data, and igor made this height one line smaller to prevent the wrong memory access.
please test again, with this cs: issue_14813_II.cs You need to save and restart the image to use the change in createGetSurfaceFormatFn (I don't know how to manually reinitialize this method). But even with this change, I can not reproduce a segfault. I will take a look at the bitblt implementation and try to find the place where the wrong memory access could happen. nicolai 2015-05-09 10:41 GMT+02:00 Ben Coman <[email protected]>: > > > On Fri, May 8, 2015 at 6:43 AM, Nicolai Hess <[email protected]> wrote: > >> >> Some testers needed! >> >> I can not reproduce the BitBlt bug and I would like to get this right, so >> that surface pattern >> paints use the correct form dimension. >> >> Prefered test setup: >> a (fresh) pharo image >> load bleeding edge from Bloc (because with bloc the whole (morphic) world >> is drawn with athens). >> change to watery theme ( because it makes some heavy use of form fills) >> verify that vertical scrollbars have this artifact (blank lines). >> load the attached code (this code reverts igors change for the 1 pixel >> extra height. >> >> please report back >> what platform windows/linux/mac 32/64 bit >> what pharo vm and image version. >> >> For me >> Windows 7 32 bit >> Win32 built on Apr 9 2015 21:05:04 Compiler: 4.6.2 >> Latest update: #50039 >> >> -> no segfault >> >> thanks in advance >> >> >> 2015-03-13 21:22 GMT+01:00 stepharo <[email protected]>: >> >>> I do not know. May be igor is reading this mailing-list but I doubt. >>> >>> >>> 2015-01-27 21:46 GMT+01:00 Nicolai Hess <[email protected]>: >>> >>> Anyone knows what this BitBlt bug is or was? >>>> 12818 <https://pharo.fogbugz.com/default.asp?12818> Last row missing >>>> 13236 <https://pharo.fogbugz.com/default.asp?13236> Fix 1 extra >>>> height for Cairo surface >>>> >>>> Because with the fix in 13236, it is not (easily) possible to make >>>> a repeating (vertical) pattern paint with 1 pixel height: >>>> 14813 <https://pharo.fogbugz.com/default.asp?14813> Wrong size for >>>> Athens surface pattern paint from a Form >>>> >>>> >>>> nicolai >>>> >>>> >>>> >>> BUMP >>> >>> >>> >>> >>> > I am unable to produce the segfault on OSX Mavericks with neither old nor > new VMs... > > Image > ----- > /Users/ben/Library/Application Support/Pharo/images/Athens > BitBlt-50041/Athens BitBlt-50041.image > Pharo5.0 > Latest update: #50041 > Unnamed > > > Virtual Machine > --------------- > /Applications/Pharo.app/Contents/MacOS/Pharo > NBCoInterpreter NativeBoost-CogPlugin-GuillermoPolito.19 uuid: > acc98e51-2fba-4841-a965-2975997bba66 May 15 2014 > NBCogit NativeBoost-CogPlugin-GuillermoPolito.19 uuid: > acc98e51-2fba-4841-a965-2975997bba66 May 15 2014 > https://github.com/pharo-project/pharo-vm.git Commit: > ed4a4f59208968a21d82fd2406f75c2c4de558b2 Date: 2014-05-15 18:23:04 +0200 > By: Esteban Lorenzano <[email protected]> Jenkins build #14826 > > Mac Cocoa Cog 5.8b12 21-Sep-10 >1B0534FA-246C-47C5-AB29-7A76C81CCDCB< > VMMaker versionString https://github.com/pharo-project/pharo-vm.git > Commit: ed4a4f59208968a21d82fd2406f75c2c4de558b2 Date: 2014-05-15 18:23:04 > +0200 By: Esteban Lorenzano <[email protected]> Jenkins build #14826 > NBCoInterpreter NativeBoost-CogPlugin-GuillermoPolito.19 uuid: > acc98e51-2fba-4841-a965-2975997bba66 May 15 2014 > NBCogit NativeBoost-CogPlugin-GuillermoPolito.19 uuid: > acc98e51-2fba-4841-a965-2975997bba66 May 15 2014 > > > > Virtual Machine > --------------- > /Users/ben/Library/Application > Support/Pharo/vm/pharo-mac-stable-vm/Contents/MacOS/Pharo > NBCoInterpreter NativeBoost-CogPlugin-EstebanLorenzano.21 uuid: > 4d9b9bdf-2dfa-4c0b-99eb-5b110dadc697 Apr 2 2015 > NBCogit NativeBoost-CogPlugin-EstebanLorenzano.21 uuid: > 4d9b9bdf-2dfa-4c0b-99eb-5b110dadc697 Apr 2 2015 > https://github.com/pharo-project/pharo-vm.git Commit: > 32d18ba0f2db9bee7f3bdbf16bdb24fe4801cfc5 Date: 2015-03-24 11:08:14 +0100 > By: Esteban Lorenzano <[email protected]> Jenkins build #14904 > > Mac Cocoa Cog 5.8b12 21-Sep-10 >1B0534FA-246C-47C5-AB29-7A76C81CCDCB< > VMMaker versionString https://github.com/pharo-project/pharo-vm.git > Commit: 32d18ba0f2db9bee7f3bdbf16bdb24fe4801cfc5 Date: 2015-03-24 11:08:14 > +0100 By: Esteban Lorenzano <[email protected]> Jenkins build #14904 > NBCoInterpreter NativeBoost-CogPlugin-EstebanLorenzano.21 uuid: > 4d9b9bdf-2dfa-4c0b-99eb-5b110dadc697 Apr 2 2015 > NBCogit NativeBoost-CogPlugin-EstebanLorenzano.21 uuid: > 4d9b9bdf-2dfa-4c0b-99eb-5b110dadc697 Apr 2 2015 > > cheers -ben > >
issue_14813_II.cs
Description: Binary data
