Henry,

> Am 19.05.2015 um 13:06 schrieb Henrik Johansen <[email protected]>:
> 
> Hi!
> I made some (imho) improvements to the OID implementation, if someone with 
> write access would find time to review/commit the attached package, I'd be 
> grateful.
> 
> The commit message:
> Make OID implementation more compatible with the description in 
> http://docs.mongodb.org/manual/reference/object-id/ 
> <http://docs.mongodb.org/manual/reference/object-id/>.
> 
> - Use the UNIX epoch instead of Smalltalk epoch for timestamp part, store BE 
> so it's pseudo-sortable by time (also, you can use getTimestamp() in mongo 
> shell and get a sensible value)

Agreed with unix epoch. The old value was in BE also which seems to be the 
right choice.
 
> - Use a per-session ID instead of localhost name for machine identification. 
> localhost name is far from unique on some platforms (always 'localhost' on 
> Macs), better with a unique ID per image session.

I do not agree. "NetNameResolver localHostName" does not return localhost for 
me. And I'd rather think the NetNameResolver does not work properly on Macs 
(not returning gethostname) instead of taking it as a reason to tweak client 
code. The id per Session wouldn't have any value because there is also a 
process id which gives you more or less the same thing.

> -  Counter initialized with a random value.
> 
Good idea.

> As an added bonus, [OID new] bench should see a ~10%  increase in performance.
> 
Even better. :) 

What do you think?

I can make you a commiter on the MongoTalk repo. What's your username?

Norbert

> Cheers,
> Henry
> <Mongo-BSON-HenrikSperreJohansen.43.mcz>
> 
>> On 08 Jul 2013, at 2:45 , François Stephany <[email protected] 
>> <mailto:[email protected]>> wrote:
>> 
>> Hi,
>> 
>> I've just created a new team for MongoTalk on SmalltalkHub: 
>> 
>> http://www.smalltalkhub.com/#!/~MongoTalkTeam 
>> <http://www.smalltalkhub.com/#%21/%7EMongoTalkTeam>
>> 
>> The old repo (http://www.smalltalkhub.com/#!/~francois/MongoTalk 
>> <http://www.smalltalkhub.com/#%21/%7Efrancois/MongoTalk>) will stay just in 
>> case some scripts rely on it but you should update to the new repo:
>> 
>> http://www.smalltalkhub.com/#!/~MongoTalkTeam/mongotalk 
>> <http://www.smalltalkhub.com/#%21/%7EMongoTalkTeam/mongotalk>
>> 
>> I've created a version 1.5.1 in the Metacello configuration to reflect the 
>> repo migration.
>> Shout at me if I missed something!
>> 
>> Cheers,
>> Fa
>> 
>> (Many thanks to Norbert for pushing the migration ;)
> 

Reply via email to