Hi nicolai

this part is a epic mess.
Just for the record we (ben and me) extracted from a global dictionary TextConstants :) TextSharedInformation
It was strange to have a changing part in a TextConstants.
So TextSharedInformation is really something that we can clean/kill/replace.

Now I think that the fact that the "findBestFont" when request for a vectorial font may return a strikefont is a bug nest.

I am about to fix some issues related to TextMorphs and fonts:

15402 <https://pharo.fogbugz.com/default.asp?15402>
wrong choose list from TextMorph editor halo

15552 <https://pharo.fogbugz.com/default.asp?15552>
chooseStyle halo from TextMorph lists only one StrikeFont
15553 <https://pharo.fogbugz.com/default.asp?15553>
choose Font halo from TextMorph lists only one StrikeFont

But  I have some questions:

TextStyle and fonts, this is bound to StrikeFonts for now, because only StrikeFonts
register themself at "TextSharedInformation" and therefore:

TextStyle actualTextStyles -> only lists the one Font "Bitmap DejaVu Sans".

There are other places that work with TextStyle default / TextStyle ....

Should I add the FreeType fonts to TextStyles TextSharedInformation
or
should I use "LogicalFontManager allFamilies" instead of "TextStyle actualTextStyles"`?

I would like to remove/cleanup all places where we use some TextStyle methods that only work for StrikeFonts, but I don't know what was the idea behind this
current state, that only works partly.

No idea. To me it looks like a huge patch.

Remove and Replace TextStyle with LogicalFontManager
or use TextStyle for Strike and FreeType fonts?

I do not know. I have the impression that LogicalFontManager is better.

thanks in advance

No thank you in advance :)


nicolai





Reply via email to