> On 20 Aug 2015, at 22:29, Nicolas Cellier > <[email protected]> wrote: > > Hi Bernardo, > I would say no: don't revert anything before testing.
Yes, we should benchmark… and this shows that if people write “special” fast code, they *really* need to document this! Now with the quality assist in place, you will find people submitting improvements for “bad” code all the time. It will be impossible to not clean if these cases are not well documented. > > 2015-08-20 19:56 GMT+02:00 Bernardo Ezequiel Contreras <[email protected] > <mailto:[email protected]>>: > Hi all, > > it seems i have changed a method (Rectangle>>#intersect:ifNone:) that could > impact in the performance of the UI. see below > > ---------- Forwarded message ---------- > From: Nicolas Cellier <[email protected] > <mailto:[email protected]>> > Date: Thu, Aug 20, 2015 at 1:18 PM > Subject: Re: [pharo-core] 50248 (3d7f1f3) > To: pharo-project/pharo-core <[email protected] > <mailto:[email protected]>> > > > IMO, min: and max: were intentionally inlined for speed purpose, since > primitive graphics objects are heavily used. > That's questionnable, but maybe still necessary on slow machines like Pi. > > — > Reply to this email directly or view it on GitHub > <https://github.com/pharo-project/pharo-core/commit/3d7f1f3ac45310096f565c2d11014df16889ad57#commitcomment-12811337>. > > > so, do i have to revert that change? > > thanks, sorry for the inconvenience > > > -- > Bernardo E.C. > > Sent from a cheap desktop computer in South America. >
