> On 24 Aug 2015, at 15:24, Thierry Goubier <[email protected]> wrote: > > > > 2015-08-24 15:11 GMT+02:00 Sven Van Caekenberghe <[email protected]>: > .... > > > > > and that timestamp: "testUnspecifiedEncoding" : > > "SvenVanCaekenberghe 8/24/2015 14:30", > > Yes, that is the correct code with a version dated today. > > > But, yes, loading in the image nets me an older version: 5/4/2014, is that > > what you have? > > The version dated 5/14/2014 is a wrong one. > The version dated 5/2/2015 would be good too. > > Thanks for having a look, Thierry. It is a good thing if at least file tree > does it correctly. > > It is even stranger: now that I get .231 correctly loaded, if I browse > changes with 230 in Zn repository, I get 'no changes' ??? > > Same if I copy .230 and .231 to a gitfiletree repository.
There is just one difference between those two versions, ZnEntityTests>>#testUnspecifiedEncoding BTW, I committed these from Pharo 3, not 5. > Now, copying .228, .229, .230 and .231 under gitfiletree and I loose track of > the testUnspecifiedEncoding change; it is associated with .228 which is > incorrect. > > I'll try again. > > > Looks like the MC side is correct (i.e. there is a correct > > MCMethodDefinition in the system). Has something changed related to code or > > methods comparisons recently? > > > > Thierry > > > > > > > > > > > On 24 Aug 2015, at 13:30, Thierry Goubier <[email protected]> > > > wrote: > > > > > > > > > > > > 2015-08-24 13:25 GMT+02:00 Thierry Goubier <[email protected]>: > > > I'm trying on 50264, and, yes, there is something strange: > > > > > > Monticello diff only picks up two of the changes, instead of three. > > > > > > Ok, by reformatting, ended up with exactly the same code for one of them > > > :( > > > > > > Saved in the package cache and I have everything saved. > > > > > > Some suspicious/wrong data in your image? > > > > > > Thierry > > > > > > > > > Thierry > > > > > > > > > 2015-08-24 12:05 GMT+02:00 Marcus Denker <[email protected]>: > > > Hi, > > > > > > I have a *very* strange bug. > > > > > > I am trying to add change these three methods in class > > > “TemporaryVariable”: > > > (I copy the new version): > > > > > > > > > ensureProperties > > > method saveTemp: self. > > > ^ Properties at: self ifAbsentPut: WeakKeyDictionary new > > > > > > removePropertiesIfEmpty > > > ^ Properties at: self ifPresent: [ :dict | > > > dict ifEmpty: [ > > > method removeSavedTemp: self. > > > Properties removeKey: self ] ] > > > > > > hash > > > > > > ^ (name hash > > > bitXor: method hash) > > > bitXor: (startpc ifNil: 0) > > > > > > > > > Now when I save the MC package, these changes are *not* saved, even > > > though when I diff against the repository > > > of Pharo5, they are shown as different. > > > > > > The only special things I did is to move TemporaryVariable to a new tag > > > some updates ago. And I had extension > > > methods in *slot where the same thing happened, but that was fixed by > > > putting them into *Slot. > > > > > > This looks like some wired RPackage problem. But the RPackage seems to > > > correctly know TemporaryVariable and these three selectors > > > as local from the package Slot. > > > > > > I really have no idea what the problem could be. > > > > > > Marcus > > > > > > > > > > > >
