2015-08-25 8:19 GMT+02:00 Nicolai Hess <[email protected]>: > > > 2015-08-24 18:21 GMT+02:00 stepharo <[email protected]>: > >> This is really nice to have people like you guys around. >> This is a really nice example where the sum is more than its elements >> >> Stef >> >> Le 24/8/15 16:44, Thierry Goubier a écrit : >> >> >> >> 2015-08-24 16:32 GMT+02:00 Marcus Denker <[email protected]>: >> >>> > >>> > solves loading Sven test packages. Marcus, can you try on yours? >>> > >>> >>> Yes! Very good! >>> >>> >> Slice pushed to 16358. We'll see what the tests say. >> >> Why has it started to fail? All the involved code is old. >> >> Thierry >> >> >>> Marcus >>> >>> >>> >> >> > Great, Thierrys solution works. > > But I think there is still a problem with RGMethodDefinition. We call > self compiledMethod > on a RGMethodDefintion, the implementation *always* returns the compiled > method from the system, if > it exists (regardless whether this ring method is active or not). > > I think we should either > - don't call #compiledMethod on ring definitions > - always return nil for not active definitions > - for non active definitions: create a compiled method on demand > > what do you think? >
It depends what we want Ring to be. If it is a replacement to MCDefinition and all, then it must handle non-active methods. If it models the live system as well, then it must answers compiledMethod. I would choose return nil or return an exception. Third one could be interesting in some contexts... running packages without loading them. But would be hard to do correctly. Thierry > > > > >
