As a side note: can we somehow write UI tests? Because this use-case could be implemented as a test to ensure future auto checks.
Uko > On 05 Sep 2015, at 12:42, Yuriy Tymchuk <[email protected]> wrote: > > I will take a look now! > > >> On 05 Sep 2015, at 11:48, Marcus Denker <[email protected] >> <mailto:[email protected]>> wrote: >> >> >>> On 05 Sep 2015, at 11:40, stepharo <[email protected] >>> <mailto:[email protected]>> wrote: >>> >>> How can I see the changes? >>> Our process is not good. Most of us do not get any chance understanding >>> what is changing. >>> >> >> -> download the image before it was added >> -> merge the slice. >> >> Yes, our process is not good… but from a review perspective, this issue is >> the best we can do. >> *two* reviews, both from people actively contributing to exactly that part >> of the system. >> >> If we require more, we will be back at a process where due to Fear we do >> nothing. >> >>> >>>> Hi, >>>> >>>> This is a side effect of >>>> >>>> https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcements-for-a-single-action >>>> >>>> <https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcements-for-a-single-action> >>>> >>>> (which was reviewed by two people, so not obvious). >>>> >>>> What happened is that #updatePackageGroupAndClassList calls itself via >>>> #selectedClass: leading to a loop. >>>> >>>> Should be easy to fix for the people involved in case 16475. >>>> >>>> Marcus >>>> >>>> >>>> On Sat, Sep 5, 2015 at 8:51 AM, stepharo <[email protected] >>>> <mailto:[email protected]>> wrote: >>>> Hi >>>> >>>> I do not know if this is linked to recent changes but we cannot remove >>>> classes or move them to another package. >>>> >>>> Stef >>>> >>>> >>>> >>>> >>>> -- >>>> -- >>>> Marcus Denker -- [email protected] <mailto:[email protected]> >>>> http://www.marcusdenker.de <http://www.marcusdenker.de/> >>> >> >
