On 6 Sep 2015 7:42 am, "Peter Uhnák" <[email protected]> wrote: >> >> git clone https://github.com/pharo-project/pharo-core.git >> cd pharo-core/ >> git show 2536752ecdd88e15b00c6d3e29cb055d108731c8 > > > But this is post-integration, we want to review things before they break something, not after. > So ideally monkey reviews code on CI and if it passes the diff is sent from CI to the mailing list. > > Also these commits combine several unrelated issues, which is not good for review. > > Isn't what Squeak uses open-source and available somewhere? Can't we just reuse it?
I thought the Squeak email diffs were post-commit?? Now what might be an interesting work flow would be when an issue is tagged Fix Review Needed and the CI monkey validates the issue it pushes the slice to a new IssueNNNNN branch in github and branch diff emailed from there. Cheers ben
