On Tue, Sep 8, 2015 at 5:32 AM, Nicolai Hess <[email protected]> wrote: > We should make sure to unregister to all announcement when the window is > closed.
+1. Nautilus seems to leak announcements. Sorry I forgot to log an issue already for this... https://www.mail-archive.com/[email protected]/msg31953.html So should I log a new issue now, or do you want to pick it up under existing work? cheers -ben > (Or is there any reason or situation in which nautilus can properly work > after the window is closed?) > > 2015-09-06 10:41 GMT+02:00 stepharo <[email protected]>: >> >> Hi >> >> I'm trying to understand what there is a need for this window ifNil: [^ >> self ] >> And I wonder is this is not problem due to a global announcer that would >> keep announcer even when the nautilus widget >> has been deleted. >> Any other suggestions? >> >> Stef >> >> classRemoved: anAnnouncement >> | class oldPackage | >> window ifNil: [ ^ self ]. >> window isDisplayed >> ifFalse: [ ^ self ]. >> class := anAnnouncement classRemoved. >> (self classWidget getClassesList includes: class) >> ifTrue: >> [ >> >> classRecategorized: anAnnouncement >> >> window ifNil: [ ^ self ]. >> window isDisplayed ifFalse: [ ^ self ]. >> self selectedPackage ifNotNil:[:selection | >> ({ anAnnouncement oldCategory. anAnnouncement newCategory } >> anySatisfy: [ :each | selection includesCategory: each ]) >> ifTrue: [ self updatePackageGroupAndClassList ]] >> >> >> classRemoved: anAnnouncement >> | class oldPackage | >> window ifNil: [ ^ self ]. >> window isDisplayed >> ifFalse: [ ^ self ]. >> class := anAnnouncement classRemoved. >> (self classWidget getClassesList includes: cla >> >
